search

fsouza / fake-gcs-server

Google Cloud Storage emulator & testing library.
https://pkg.go.dev/github.com/fsouza/fake-gcs-server/fakestorage?tab=doc
BSD 2-Clause "Simplified" License
1k stars 210 forks source link

[Feature Request] Support response-content-disposition and response-content-type query? #477

Open anchan828 opened 3 years ago

anchan828 commented 3 years ago

Hi, thank you for this useful tool!

I would like to see support for response-content-disposition and response-content-type because I want to have the same behavior as GCS.

https://cloud.google.com/storage/docs/xml-api/reference-headers#responsecontentdisposition

fsouza commented 3 years ago

Hi @anchan828, thanks for opening this issue. Is that feature also supported in the json-api? You linked the xml-api, which is not currently supported (see #331).

anchan828 commented 3 years ago

Hi @fsouza, thanks for your reply. Those parameters work fine at least in @google-cloud/storage. Also google-cloud-cpp have them. This feature does not seem to make a difference between json and xml, I think.

fsouza commented 3 years ago

Nice, thanks for confirming!