search

fsouza / go-dockerclient

Go client for the Docker Engine API.
https://pkg.go.dev/github.com/fsouza/go-dockerclient?tab=doc
BSD 2-Clause "Simplified" License
2.18k stars 564 forks source link

github.com/ijc/Gotty is unmaintained... #804

Closed onlyjob closed 5 years ago

onlyjob commented 5 years ago

github.com/ijc/Gotty is unmaintained, according to https://github.com/Nvveen/Gotty/issues/5.

It is used only in one place: https://github.com/fsouza/go-dockerclient/blob/master/internal/jsonmessage/jsonmessage.go#L17

Any alternatives?

fsouza commented 5 years ago

Hey @onlyjob, what issue are you running into?

I can go look for something else or vendor gotty into go-dockerclient/fix the issue, but I'd like to understand what's going on first.

onlyjob commented 5 years ago

Just a concern regarding life cycle and dependency hygiene. :)

Basically there is no github.com/ijc/Gotty on Debian and introducing unmaintained library as a standalone/reusable package is not a good idea... Without github.com/ijc/Gotty recent releases of go-dockerclient FTBFS...

For now I could probably do something like 

--- golang-github-fsouza-go-dockerclient-1.4.4.orig/client.go
+++ golang-github-fsouza-go-dockerclient-1.4.4/client.go
@@ -33,7 +33,7 @@ import (

        "github.com/docker/docker/pkg/homedir"
        "github.com/docker/docker/pkg/stdcopy"
-       "github.com/fsouza/go-dockerclient/internal/jsonmessage"
+       "github.com/docker/docker/pkg/jsonmessage"
 )

 const (

but I think it would be better to address the root cause which is dependency on "dead" (unmaintained) code...

fsouza commented 5 years ago

Gotcha. Will fix.

onlyjob commented 5 years ago

Thanks. :)