fspc / Yellow-Bike-Database

Yellow Bike Project Hours and Transaction Database for Community Bike Shops
GNU General Public License v3.0
7 stars 1 forks source link

Patron who is both member and volunteer isn't receiving membership benefit percentage for transaction type that is membership benefit only #21

Closed fspc closed 7 years ago

fspc commented 7 years ago

Thought this was working properly, may have broke at some point.

fspc commented 7 years ago

This is correct behavior. Remaining volunteer hours take precedence over membership percentage.

fspc commented 7 years ago

Actually, it is correct behavior if there are still volunteer hours left and the item is a transaction type with volunteer benefits, however, if it is a transaction with membership benefits, and there is not a matching transaction type with volunteer benefits then the membership discount should be applied.