search

fsphil / fswebcam

A neat and simple webcam app
http://www.sanslogic.co.uk/fswebcam/
GNU General Public License v2.0
416 stars 87 forks source link

src_v4l1.c:101: possible bad test ? #31

Open dcb314 opened 8 years ago

dcb314 commented 8 years ago

src_v4l1.c:101]: (style) Boolean result is used in bitwise operation. Clarify expression with parentheses.

Source code is

if(!vd->type & VID_TYPE_CAPTURE)

Maybe better code

if ( ! (vd->type & VID_TYPE_CAPTURE))

Also:

src_v4l2.c:106]: (style) Boolean result is used in bitwise operation. Clarify expression with parentheses.

Duplicate.