search

fsphil / hacktv

Analogue TV transmitter for the HackRF
GNU General Public License v3.0
669 stars 80 forks source link

clang warnings #87

Closed dforsi closed 2 years ago

dforsi commented 2 years ago

Compiling with Debian clang version 13.0.1-+rc3-1~exp1+b1 shows the following warnings:

$ make CC=clang

video.c:1620:23: warning: implicit conversion from 'double' to 'int' changes value from 7.499999999999999E-5 to 0 [-Wliteral-conversion]
        .fm_mono_preemph   = 0.000075, /* Seconds */
                             ^~~~~~~~

mac.c:994:27: warning: implicit conversion from 'unsigned long' to 'uint8_t' (aka 'unsigned char') changes value from 18446744073709551604 to 244 [-Wconstant-conversion]
        return(hsync ? MAC_LSW : ~MAC_LSW);
        ~~~~~~                   ^~~~~~~~
fsphil commented 2 years ago

Thanks for the report. These should be fixed now.