View metadata when Peek Definitions on external assemblies

fsprojects-archive / zzarchive-VisualFSharpPowerTools

[ARCHIVED] Power commands for F# in Visual Studio

http://fsprojects.github.io/VisualFSharpPowerTools/

Apache License 2.0

310 stars 77 forks source link

View metadata when Peek Definitions on external assemblies #1369

Closed dungpa closed 8 years ago

dungpa commented 8 years ago

Close #1314.

Refactor Navigate to Metadata feature in order to enable Peek Definition.

I haven't tested with VS 2015 so far; just ensure that Go to Definition stills work as is.

@vasily-kirichenko Could you help test Peek Definitions on VS 2015 on external assemblies?

vasily-kirichenko commented 8 years ago

Add reference to Microsoft.VisualStudio.Shell.12.0 in VS2015 project.

vasily-kirichenko commented 8 years ago

When I press Alt+F12, VS 2015 freezes indefinitely. The UI thread stack trace:

If I click on this icon:

It unfreezes and the peek definition window appears:

Also System.Guid.fsi file is open in VS (as a separate normal view). While it's open Alt+F12 works perfectly for Guid, once it's closed, the issue is back.

dungpa commented 8 years ago

@vasily-kirichenko Done. Could you give it a try?

vasily-kirichenko commented 8 years ago

Works perfectly.

vasily-kirichenko commented 8 years ago

Great job!

dungpa commented 8 years ago

Thanks.