build.cmd compiles projects with F# 3.1

fsprojects-archive / zzarchive-VisualFSharpPowerTools

[ARCHIVED] Power commands for F# in Visual Studio

http://fsprojects.github.io/VisualFSharpPowerTools/

Apache License 2.0

310 stars 77 forks source link

build.cmd compiles projects with F# 3.1 #1419

Closed vasily-kirichenko closed 8 years ago

vasily-kirichenko commented 8 years ago

Look at https://ci.appveyor.com/project/dungpa/visualfsharppowertools/build/2.6.0-a1607121916

C:\Program Files (x86)\Microsoft SDKs\F#\3.1\Framework\v4.0\fsc.exe

and an error conforming F# 3 is used:

...\EventHandling.fs(99,20): error FS0407: The mutable variable 'cts' is used in an invalid way. Mutable variables cannot be captured by closures. Consider eliminating this use of mutation or using a heap-allocated mutable reference cell via 'ref' and '!'.

dungpa commented 8 years ago

We should remove this part https://github.com/fsprojects/VisualFSharpPowerTools/blob/8e4b367d147456d0ecfafbca879090b241286fbb/build.fsx#L51-L54.

vasily-kirichenko commented 8 years ago

Yeah, just found it.

vasily-kirichenko commented 8 years ago

Fixed in https://github.com/fsprojects/VisualFSharpPowerTools/pull/1420