fsprojects-archive / zzarchive-VisualFSharpPowerTools

[ARCHIVED] Power commands for F# in Visual Studio
http://fsprojects.github.io/VisualFSharpPowerTools/
Apache License 2.0
310 stars 77 forks source link

Normalize namespaces #1422

Closed vasily-kirichenko closed 7 years ago

vasily-kirichenko commented 7 years ago

WIP

dungpa commented 7 years ago

You've gotta normalize namespaces on all XAML files e.g. https://github.com/vasily-kirichenko/FSharpVSPowerTools/blob/c3affcbdccff2321fe13ebe6d69874462585f956/src/FSharp.Editing.VisualStudio/FolderNameDialog.xaml#L5-L19; otherwise, none of the XAML dialogs would work.

smoothdeveloper commented 7 years ago

@dungpa regarding XAML (which I don't know anything of) any clue if Resharper would catch that as error? I can give a look at what Resharper says.

dungpa commented 7 years ago

I'm not sure ReSharper works on XAML files in F# projects. You could give it a try.

ReedCopsey commented 7 years ago

From what I've seen, you'll have to hand-edit the xaml files to fix the namespaces (and assembly names) in the headers.

On Thu, Jul 14, 2016 at 2:08 PM, Anh-Dung Phan notifications@github.com wrote:

I'm not sure ReSharper works on XAML files in F# projects. You could give it a try.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/fsprojects/VisualFSharpPowerTools/pull/1422#issuecomment-232793031, or mute the thread https://github.com/notifications/unsubscribe/AFCUmtkxgwtACWdLXSs_IELg-fKCHTfkks5qVqVggaJpZM4JMywS .

smoothdeveloper commented 7 years ago

image

Resharper at the rescue, it picks (at least the assembly) errors up.

@vasily-kirichenko do you want me to make a PR on your branch?

smoothdeveloper commented 7 years ago

It also completes on namespaces it seems: image

ReedCopsey commented 7 years ago

Yes, and if you remove the entire xmlns line, then go to the first error, it should pick up what needs to be added and prompt to add it. Still needs to manually check each xaml, but it does help.

On Thu, Jul 14, 2016 at 3:02 PM, Gauthier Segay notifications@github.com wrote:

It also completes on namespaces it seems: [image: image] https://cloud.githubusercontent.com/assets/87944/16857336/6aaf095e-4a1f-11e6-9e43-f30a2c51a2fc.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/fsprojects/VisualFSharpPowerTools/pull/1422#issuecomment-232805862, or mute the thread https://github.com/notifications/unsubscribe/AFCUmrQRFZl92r23O7y-2B9kt90zgmjcks5qVrH_gaJpZM4JMywS .

smoothdeveloper commented 7 years ago

https://github.com/vasily-kirichenko/FSharpVSPowerTools/pull/8

vasily-kirichenko commented 7 years ago

It's ready.

dungpa commented 7 years ago

Great. Thanks.