search

fsprojects-archive / zzarchive-VisualFSharpPowerTools

[ARCHIVED] Power commands for F# in Visual Studio
http://fsprojects.github.io/VisualFSharpPowerTools/
Apache License 2.0
310 stars 77 forks source link

Xml Documentation of VS SDK #1425

Closed smoothdeveloper closed 7 years ago

smoothdeveloper commented 7 years ago

We have VS SDK assemblies in those folders :

https://github.com/fsprojects/VisualFSharpPowerTools/tree/master/lib/vs2015

it would be convenient to add the .xml so we have documentation while editing the code.

dungpa commented 7 years ago

My suggestion is to move all these assemblies to NuGet packages and handle them via Paket https://www.nuget.org/profiles/VisualStudioExtensibility.

smoothdeveloper commented 7 years ago

Ok, I'll do a PR for this.

smoothdeveloper commented 7 years ago

I've been as far as having all projects to compile off the nuget packages, with all the separate version of VSSDK, although couldn't figure out the Microsoft.TC.* ones so those remain in the lib folder (as well as the native files).

Now the VSIX build still gives an error which I'm not able to figure out at this time.

dungpa commented 7 years ago

The test assemblies (Microsoft.TC.*) are no longer used. They can be removed I think. Native assemblies might come with SourceLink NuGet package though I'm not sure. They can stay there if we can't find them anywhere.

smoothdeveloper commented 7 years ago

@dungpa TestUtilities project (which I assume is not really our code) doesn't compile without those. Our own VS test assembly depends on that project.

dungpa commented 7 years ago

You can choose to remove the classes that use these references if it's easy; otherwise, just leave them intact in lib folder. We don't use this piece of test functionalities at all.