[Rename] Does not work

[vasily-kirichenko]

master

[dungpa]

Could you git bisect? There were a few PRs that touched XAML recently.

[smoothdeveloper]

Confirm the same.

[cloudRoutine]

1451 should fix this, the uri needed to be updated do properly access the resource dictionary. There was a warning for it in the xaml file, but treat warnings as errors doesn't seem to apply to xaml :expressionless:

[ReedCopsey]

@cloudroutine does that fix need to happen to any other xaml files? I thought the resources were shared with other UIs.

On Jul 22, 2016 7:03 PM, "Jared Hester" notifications@github.com wrote:

1451 https://github.com/fsprojects/VisualFSharpPowerTools/pull/1451

should fix this, the uri needed to be updated do properly access the resource dictionary. There was a warning for it in the xaml file, but treat warnings as errors doesn't seem to apply to xaml 😑

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/fsprojects/VisualFSharpPowerTools/issues/1450#issuecomment-234693023, or mute the thread https://github.com/notifications/unsubscribe-auth/AFCUmgARvrzGWt8tvpDsLLr39BLBvwhHks5qYXZ7gaJpZM4JS_7b .

[cloudRoutine]

@ReedCopsey good call, I'd missed two. Although now I'm having this weird issue in the designer.

Last time I had visual studio open changing the uri fixed the error that was preventing it from loading. This time RenameDialog, FolderNameDialog, MoveToFolderDialog all wouldn't load initially despite working in the experimental instance, then once I clicked on the error bubble that comes up in the solution explorer when you mouse over the filename, it all worked again. :confused:

[cloudRoutine]

@ReedCopsey do you know of a way we could catch these sorts of errors at compile time over runtime?

[vasily-kirichenko]

Fixed via https://github.com/fsprojects/VisualFSharpPowerTools/pull/1451

[ReedCopsey]

@cloudroutine I don't know of a way. it's a problem for c# too. ReSharper finds it if the xaml is open, but even that's not reliable.

On Jul 22, 2016 10:57 PM, "Jared Hester" notifications@github.com wrote:

@ReedCopsey https://github.com/ReedCopsey do you know of a way we could catch these sorts of errors at compile time over runtime?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fsprojects/VisualFSharpPowerTools/issues/1450#issuecomment-234701504, or mute the thread https://github.com/notifications/unsubscribe-auth/AFCUmnGkPcONSqdx45IgtMHPgcYt6xUXks5qYa07gaJpZM4JS_7b .