search

fsprojects-archive / zzarchive-VisualFSharpPowerTools

[ARCHIVED] Power commands for F# in Visual Studio
http://fsprojects.github.io/VisualFSharpPowerTools/
Apache License 2.0
310 stars 77 forks source link

Possible VsVim Conflict: Matching Parentheses Highlight #1494

Closed jeroldhaas closed 7 years ago

jeroldhaas commented 7 years ago

Description

When using VsVim to edit a .fs or .fsx file, highlighting of matching braces doesn't work. Disabling VsVim restores the behavior. Other file types work with matching brace / parenthesis highlighting.

Repro steps

Please provide the steps required to reproduce the problem

  1. Install VsVim if not already installed & activated.
  2. Open .fs or .fsx file with matching parentheses / braces or write code with them therein.
  3. Note missing highlight behavior. Disable VsVim (Ctrl+Shift+F12 is default toggle) and note restoration of behavior. Re-enable VsVim and note behavior is missing again.

Expected behavior

Braces & parentheses ((, ), [, ], {, }) should show matching character.

Actual behavior

Placing the caret over one of the "supported" characters yields no highlight for the matching character.

Known workarounds

Current workaround is to disable VsVim, which removes all vim-style editing capabilities.

Related information

vasily-kirichenko commented 7 years ago
  1. We don't do parens highlighting in this extension
  2. This project is obsolete
  3. Brace highlighting is done in Visual F# Tool
  4. It was completely rewritten with Roslyn VS infrastructure in VS 2017
  5. Nobody is gonna fix any bugs in VS 2015 and earlier versions

So, in short, grab VS 2017 RC and check if the bug is gone.

jeroldhaas commented 7 years ago

Wow. Ok, Vasily. Thanks.

dsyme commented 7 years ago

@vasily-kirichenko Perhaps there are some drink(s) we could buy you to make one service release for VS2015 at some point? :) :) Just wondering if it might help the community grow in the enterprise situations where they will no doubt be stuck on VS2015 for a while :)

vasily-kirichenko commented 7 years ago

@dsyme that's a bug in VFT, not in VFPT, as I said. We don't touch brace matching at all.

dsyme commented 7 years ago

@dsyme that's a bug in VFT, not in VFPT, as I said. We don't touch brace matching at all.

Yep, understood. I just wanted to raise the prospect of a service release at some point :) Though fundamentally the convergence with VFT is awesome :)

vasily-kirichenko commented 7 years ago

:) The last VFPT release was long time ago and no serious bugs have been found so far. So, if there are bugs, I'll certainly fix them.

smoothdeveloper commented 7 years ago

@ReedCopsey was calling out to release a new version with latest FSharpXaml to avoid issues for end-users:

1495

vasily-kirichenko commented 7 years ago

@smoothdeveloper somehow I forget about it :( It's just released.