fsprojects-archive / zzarchive-VisualFSharpPowerTools

[ARCHIVED] Power commands for F# in Visual Studio
http://fsprojects.github.io/VisualFSharpPowerTools/
Apache License 2.0
310 stars 77 forks source link

Cannot build VS2012 solution after migrating to FsXaml #190

Closed dungpa closed 10 years ago

dungpa commented 10 years ago

I've got this warning in VS2012:

Warning 17 Referenced assembly 'C:\PowerTools\packages\FsXaml.Wpf.0.9.2\lib\net45\FsXaml.Wpf.TypeProvider.dll' has assembly level attribute 'Microsoft.FSharp.Core.CompilerServices.TypeProviderAssemblyAttribute' but no public type provider classes were found

and all errors are due to the fact that the type provider fails to load.

dungpa commented 10 years ago

@ReedCopsey Do you know the cause of this? The repro is to compile FSharpVSPowerTools.v11.sln in VS2012 using F# 3.0 compiler on a machine with both VS2012 and VS2013 installed.

ReedCopsey commented 10 years ago

@dungpa I'll investigate ASAP. I hadn't designed FsXaml with 2012 support in mind (wasn't a design goal), but I think everything should be possible to make work with it, at least on the WPF side. Will see what I can do.

dungpa commented 10 years ago

Thanks. We support VS2012 onwards so it would be of great help to be able to use FsXaml in VS2012.

ctaggart commented 10 years ago

Is it possible to target VS 2012 and above, but require VS 2013 to build the solution so that we can target .NET 4.5 and F# 3.1? Many projects have already moved to F# 3.1. This includes FsXaml, Fantomas, my SourceLink project. Right now, there are several warnings when builds the projects due to using FSharp.Core 4.3.0.0 vs 4.3.1.0. I think it is possible, but someone should test.

ghost commented 10 years ago

Aaargh, mobile github makes it too easy to close issues accidentally :)

ghost commented 10 years ago

What's the value in using F# 3.1 or FSharp.Core 4.3.1.0 for this project? (note these are independent decisions - you can use FSharp.Core 4.3.0.0 with F# 3.1 projects).

ctaggart commented 10 years ago

Thanks Don. Makes sense. In this case, just need to make sure FsXaml and other upstream libraries target FSharp.Core 4.3.0.0.

ReedCopsey commented 10 years ago

@dsyme I'm working on this now. Biggest problem I'm finding is in dependencies, which were 4.3.1.0 in order to use PCL in 2013. I think this will require a completely separate project for 4.3.0.0. I have an approach in mind, but it's ugly

ReedCopsey commented 10 years ago

@dungpa I believe this PR should correct the issue. Let me know if there are any other problems with it.

dungpa commented 10 years ago

It works great. Thanks a lot for quick responses.