search

fsprojects-archive / zzarchive-generator-fsharp

[ARCHIVED] Yeoman F# generator
Apache License 2.0
62 stars 27 forks source link

build failed under Ubuntu 15.10 #37

Closed andyczerwonka closed 7 years ago

andyczerwonka commented 8 years ago

I downloaded the latest version and tried to build the default console application with no changes. Simply ran yo fsharp and accepted the defaults.

aczerwon groot -work-fs-hello_036

andyczerwonka commented 8 years ago

Here's a screenshot of running the build inside Atom. Looks like it doesn't like [<EntryPoint>]

fs-hello fs -home-aczerwon-work-fs-hello atom_037

Krzysztof-Cieslak commented 8 years ago

Try to create project with name not containing special characters (- in your case)

andyczerwonka commented 8 years ago

@Krzysztof-Cieslak yes, that now works. Is that documented somewhere of is this a bug?

juergenhoetzel commented 7 years ago

@Krzysztof-Cieslak yes, that now works. Is that documented somewhere of is this a bug?

I also hit this issue multiple times. IMO it would be nice to validate the application-name input, because it is used also as module name.

I added a validation function in https://github.com/fsprojects/generator-fsharp/pull/51

juergenhoetzel commented 7 years ago

First commit was a bit too rigorous. digits are valid identifiers if they don't appear as starting character of an identifier. This is fixed in https://github.com/fsprojects/generator-fsharp/pull/51/commits/7bec11d64868cc38b1436763804d26e3323fd5b5 added to the pull request.

juergenhoetzel commented 7 years ago

@andyczerwonka I guess by merging #51 this can be closed now?

Krzysztof-Cieslak commented 7 years ago

Fix released in 0.5.3

juergenhoetzel commented 7 years ago

Fix released in 0.5.3

Fix is only in develop branch :thinking: