fsprojects / Argu

A declarative CLI argument parser for F#
https://fsprojects.github.io/Argu
MIT License
453 stars 75 forks source link

WIP: Added equality and comparison to ParseResults<_>. #137

Closed kleidemos closed 4 years ago

kleidemos commented 5 years ago

I had problem when I added a subcommand case to Arguments. Because DU containing ParseResults<_> loses structural equality and comparison. I think comparing a ParseResults<_> by GetAllResults is a good idea.

eiriktsarpalis commented 5 years ago

Thanks for the PR, but I think I won't be merging this for the following reasons:

kleidemos commented 5 years ago
eiriktsarpalis commented 5 years ago

Fair enough. Can revisit if you could cache the result for comparison purposes and add a few tests.

eiriktsarpalis commented 4 years ago

Thanks