fsprojects / Argu

A declarative CLI argument parser for F#
https://fsprojects.github.io/Argu
MIT License
453 stars 75 forks source link

Release 6.1.2 #192

Closed nojaf closed 9 months ago

nojaf commented 9 months ago

This is an attempt to perform a release via a manual dispatch action. I'd like to start with just being able to run the release, we can improve some stuff in the future afterwards.

resolves #166 fixes #116 fixes #159

bartelink commented 9 months ago

FYI I turned off merge commits just now (as well as wikis and projects) as https://github.com/fsprojects/Argu/commits/master/ seems unnecessarily messy (IME you either need to police commits and go around requesting rebasing, or just stick to squash merges). Open to debate though.

bartelink commented 9 months ago

Hm seeing lots of build work, (~#160 and~ Got confused; I refer to the PRs that fixed things in the release notes rather than the issues) #127 on master since the last release, so maybe 6.1.2 is not appropriate?

If this was me, I'd be tempted to merge my two PRs and mint a 7.0.0-rc.1, then turn it RC after we prove it's correct wrt jumping to source and the deterministic build flags at https://nuget.info/packages/Argu etc

It'd be good to have the release number in the title of these PRs too (personally in general I tend to use MinVer and put tags on commits, but then I don't have the FAKE skills to do it the hard way!)

nojaf commented 9 months ago

Hmm, yeah I'm on the fence for this one. I might just want to try this first and then go for the 6.2.0-alpha-001 with #174 and #187. I don't think we are really breaking anything in those PRs? I could be wrong, so please point it out if those do contain breaking changes.

bartelink commented 9 months ago

Agree probably not breaking anything (was avoiding thinking about it!) and 7.0 is trumpeting things to an unwarranted degree note re 6.2.0-alpha-001, better to make that 6.2.0-alpha.1 - dotted parts mean no zero prefixing required in recent semvers AFAIK. (And it's a -beta or -rc to my mind!)