chore: Set Git identity for gh-pages commits

fsprojects / Argu

A declarative CLI argument parser for F#

https://fsprojects.github.io/Argu

MIT License

453 stars 75 forks source link

chore: Set Git identity for gh-pages commits #198

Closed nojaf closed 9 months ago

nojaf commented 9 months ago

The git identity needs to be set in https://github.com/fsprojects/Argu/actions/runs/7181861887/job/19557118490

Because a commit is being pushed to the gh-pages branch.

bartelink commented 9 months ago

aside: some thoughts on conventional commits naming

nojaf commented 9 months ago

Thanks!

aside: https://github.com/fsprojects/fsharp-cheatsheet/pull/20#issuecomment-1772684284

I can't say I care enough for this project to start doing this. I don't do this anywhere and life goes on. I don't mind if you can't help yourself and want to change the titles. But I'm not sure if I see myself doing this. Changes might increase if a tl;dr of this was listed in the PR template. Hope I'm not coming off as rude, just being upfront about my thoughts.

bartelink commented 9 months ago

Yes, that's perfectly reasonable; appreciate the frankness (But you will look back on this as a "wow it took me a while to get into it at the start!" thing some day :D)

The sell for me is that it feels like it helps me formulate shorter but more informative PR titles...