search

fsprojects / Argu

A declarative CLI argument parser for F#
https://fsprojects.github.io/Argu
MIT License
451 stars 75 forks source link

fix: Remove incorrect Dotnet.ReproducibleBuilds ref #202

Closed bartelink closed 8 months ago

bartelink commented 8 months ago

Version 6.1.3 has an incorrect additional reference

~Per https://github.com/fsprojects/Paket/issues/2951 this should remove that...~ Resolved by using a PackageReference rather than fighting paket on this one

bartelink commented 8 months ago

Unfortunately local build still shows it in the nuspec:

<group targetFramework=".NETStandard2.0">
        <dependency id="DotNet.ReproducibleBuilds" version="1.1.1" exclude="Build,Analyzers" />

Hm, is Paket worth it in this repo...

.@nojaf obv not safe to merge yet...

nojaf commented 8 months ago

I am all ears to remove Paket if that was the question 😅

bartelink commented 8 months ago

Yeah, paket is definltely overkill for a small library

I guess my issue is that it could mean time fighting FAKE...

bartelink commented 8 months ago

https://github.com/jet/equinox/blob/master/Directory.Build.props#L17 works for Equinox

And it removes the reference on my machine...

bartelink commented 8 months ago

Seems happy now: https://www.nuget.org/packages/Argu/6.1.4

bartelink commented 8 months ago

@sergey-tihon Would you mind unlisting 6.1.3 please (assuming you have the permissions?)

sergey-tihon commented 8 months ago

done