search

fsprojects / Argu

A declarative CLI argument parser for F#
https://fsprojects.github.io/Argu
MIT License
451 stars 75 forks source link

fix(Mandatory args): list missing cases #236

Closed fpellet closed 5 months ago

fpellet commented 5 months ago

A regression has occurred in https://github.com/fsprojects/Argu/pull/127

Previously, if a case was missing, help was displayed for the subcommand and not for the main command. This was the same behaviour as when there was an unknown case. This PR corrects this to restore the old behaviour.

At the same time, the error message when a case is missing has been improved. It used to display only the first missing case. Now it displays all the missing cases.

fpellet commented 5 months ago

Thank you for noticing and fixing - can you also add a mention to the release notes please (call it 6.2.3)

I have update release note. Minor version because it changes the text of the error message, and display all missing cases

bartelink commented 5 months ago

Thanks for all the follow-ups and for bearing with all my pedantry. I think there's one nit outstanding, but if you don't get to it in the next bit I'll merge and release later on.

bartelink commented 5 months ago

Released; thanks for another excellent contribution!