fsprojects / Avalonia.FuncUI

Develop cross-plattform GUI Applications using F# and Avalonia!
https://funcui.avaloniaui.net/
MIT License
889 stars 72 forks source link

Use isNull for null checks #410

Closed Numpsy closed 2 months ago

Numpsy commented 3 months ago

Some suggestions that I got when testing with the analyzers at https://github.com/ionide/ionide-analyzers/pull/85

JaggerJo commented 3 months ago

I actually prefer just having operators. Is there a good reason to use 'isNull' instead?

Numpsy commented 3 months ago

It's supposed to generate more efficient code (there's some discussion and links in the FSharpLint issue at https://github.com/fsprojects/FSharpLint/issues/439).

Saying that, quite possibly it doesn't really matter for cases in the diagnostics tools etc