search

fsprojects / AzureStorageTypeProvider

An F# Azure Type Provider which can be used to explore Blob, Table and Queue Azure Storage assets and easily apply CRUD operations on them.
http://fsprojects.github.io/AzureStorageTypeProvider/
The Unlicense
84 stars 34 forks source link

Why does downloadFolder call Async.Start? #58

Closed ahmelsayed closed 8 years ago

ahmelsayed commented 8 years ago

I don't think that downloadFolder should be calling Async.Start. I would think that it should just return the Async<unit> so that the caller of Download(path) can await it.

isaacabraham commented 8 years ago

You could be right - it was originally used within scripts where it just seemed to be easier to use if it didn't need to be awaited. Happy to accept a PR that changes this.

ahmelsayed commented 8 years ago

Thanks @isaacabraham I opened #59