search

fsprojects / AzureStorageTypeProvider

An F# Azure Type Provider which can be used to explore Blob, Table and Queue Azure Storage assets and easily apply CRUD operations on them.
http://fsprojects.github.io/AzureStorageTypeProvider/
The Unlicense
84 stars 34 forks source link

Don't call Async.Start on downloadFolder #59

Closed ahmelsayed closed 8 years ago

ahmelsayed commented 8 years ago

Fixes #58

I just removed the call to |> Async.Start which works if the caller takes care of the Async<unit>.

Though as far as I understand, and I'm kind of new to this, that will be a change in behavior since Async<'a> in F# doesn't start until you explicitly run them, right? Would something like this be more correct?

|> Async.StartChild

or

|> Async.StartAsTask
|> Async.AwaitTask

I'm not too sure how someone would've used Download(path) predictably.

dsyme commented 8 years ago

The caller can just use Async.RunSynchronously if necessary/appropriate

ahmelsayed commented 8 years ago

Yeah I figured that, I was worried about changing the current behavior, but cool that makes it simpler