search

fsprojects / Chessie

Railway-oriented programming for .NET
http://fsprojects.github.io/Chessie/
The Unlicense
188 stars 43 forks source link

Small improvements #15

Closed pblasucci closed 9 years ago

pblasucci commented 9 years ago
forki commented 9 years ago

I'm on vacation, but feel free to :shipit: and release it.

pblasucci commented 9 years ago

After thinking about thing for a bit, I reverted the Result union back to OK or Fail. I also added a pass function (basically an alias to ok), and an Active Pattern for looking at a result as being either:

These changes keep the original code basically unchanged. However, they allow for an additional "three-track" workflow which fits inside the "two-track" ROP model. I also added a help doc demonstrating the usage of the new constructs.

mexx commented 9 years ago

Honestly I find such PRs really hard to review, as there are multiple things going on and the reformatting adds more struggle. IMHO Mark Seemann (aka @ploeh) has a great write on this.

pblasucci commented 9 years ago

So, I don't normally like to merge my one pull requests. But this one's been sitting out a while (and at this point I've incorporated all of the feedback), so I thought I'd go and release it. However, when I looked at the repo a bit more closely, I'm very confused. I see that GitHub Releases and NuGet have version numbers which don't correspond to the Release Notes.

So, what's up with that?

forki commented 9 years ago

Sorry I'm on vacation. Otherwise I'd have merged and released it.

Feel free to shipit. Maybe use 0.1 as version number On Mar 19, 2015 9:52 PM, "Paulmichael Blasucci" notifications@github.com wrote:

So, I don't normally like to merge my one pull requests. But this one's been sitting out a while (and at this point I've incorporated all of the feedback), so I thought I'd go and release it. However, when I looked at the repo a bit more closely, I'm very confused. I see that GitHub Releases and NuGet have version numbers which don't correspond to the Release Notes https://github.com/fsprojects/Chessie/blob/master/RELEASE_NOTES.md.

So, what's up with that?

— Reply to this email directly or view it on GitHub https://github.com/fsprojects/Chessie/pull/15#issuecomment-83757493.

pblasucci commented 9 years ago

@forki Sorry to bother you on holiday... I'll update the version and ship it.

Thanks!