search

fsprojects / Chessie

Railway-oriented programming for .NET
http://fsprojects.github.io/Chessie/
The Unlicense
188 stars 43 forks source link

Fix #39

Closed kellerd closed 8 years ago

kellerd commented 8 years ago

Addresses interop with VB.NET #38

e7e1ff8 Adds [<assembly: ExtensionAttribute()>] to AssemblyInfo.fs, Adds AssemblyInfo.fs to Chessie.fsproj 7b9c724 Creates test projects for VB using code from the C# project 02ff8a9 Adds test project to solution, may want to exclude this one and do it manually as it seems my version Visual Studio is ahead of the project

forki commented 8 years ago

/cc @mexx what do you think?

forki commented 8 years ago

could you please take a look at the travis/mono build?

mexx commented 8 years ago

LGTM, besides the travis/mono build error.

kellerd commented 8 years ago

After some investigation, and learning looks like the mono vb.net compiler is basically running Visual Basic 8 from Visual Studio 2005, with no plans to upgrade beyond that.

So things in the tests that have come since then, don't work:

Auto-Properties Object Initialization using With Lambdas List Initialization using {} Linq query syntax

I'll assume you guys would still want tests written, so I'll re-implement them old school style.

kellerd commented 8 years ago

Ok, need some suggestions here on how you guys would like me to proceed.

Had a lapse, forgetting in 2005 we also didn't have Extension methods, which is what this PR is specifically trying to enable for VB. Mono has no support for it (in VB), and will likely never.

From what I've read quickly so far, baring some ugly hacks, the tests would go from:

Testing calling the extension methods in VB to Can I call an F# library from VB with some ugly hackish code.

Should I

mexx commented 8 years ago

I would vote for simply exclude the tests on mono, as VB support is that much limited on mono.

forki commented 8 years ago

Yes. Either somehow ifdef the stuff or just delete the Vb project altogether. On Jan 29, 2016 21:26, "Max Malook" notifications@github.com wrote:

I would vote for simply exclude the tests on mono, as VB support is that much limited on mono.

— Reply to this email directly or view it on GitHub https://github.com/fsprojects/Chessie/pull/39#issuecomment-176953172.

kellerd commented 8 years ago

Removed the project. It builds, learned a lot from what started as a simple effort and proof of concept for work.

forki commented 8 years ago

thanks!