search

fsprojects / ExcelFinancialFunctions

.NET Standard library providing the full set of financial functions from Excel.
https://fsprojects.github.io/ExcelFinancialFunctions
Other
196 stars 66 forks source link

FSharp.Core 4.3.4 Nuget update #21

Closed vkirienko closed 3 years ago

vkirienko commented 6 years ago

Hi,

I'm trying to update FSharp.Core to 4.3.4 version using Nuget and getting error below.

Unable to resolve dependencies. 'FSharp.Core 4.3.4' is not compatible with 'ExcelFinancialFunctions 2.4.0 constraint: FSharp.Core (>= 4.0.0.1 && < 4.0.1)'.

Maybe it is good idea to relax upper version requirement?

Regards, Vlad Kirienko

luajalla commented 6 years ago

Hi Vlad, Thanks for reporting this. Could you please create a PR? It will probably work with the new version, but needs a quick test...

Cheers, Natallie

Thorium commented 5 years ago

Yes, this is very restrictive, NuGet.org says "FSharp.Core (>= 4.0.0.1 && < 4.0.1)". It does work with later versions also, if the Nuget package wouldn't have that.

jcoliz commented 3 years ago

A PR to address this issue has been merged.