fsprojects / ExcelProvider

This library is for the .NET platform implementing a Excel type provider.
http://fsprojects.github.io/ExcelProvider/
The Unlicense
141 stars 51 forks source link

GitHub issue 41 #108

Closed mjdupont closed 2 months ago

mjdupont commented 2 months ago

I was hoping to address Issue #41. It looks like this was mostly due to some off-by-one indexing errors. I added one or two simple tests to address the issue, and needed to adjust other tests which were relying on the extra, empty rows being present. All tests are currently passing locally.

There are some extra changes appearing due to fantomas formatting. I'll comment to highlight the relevant changes where made.

I definitely think that the discussion in the issue about how this could break existing processes should be addressed before this can be moved forward.