search

fsprojects / ExcelProvider

This library is for the .NET platform implementing a Excel type provider.
http://fsprojects.github.io/ExcelProvider/
The Unlicense
141 stars 51 forks source link

Additional type coercion #110

Closed mjdupont closed 2 weeks ago

mjdupont commented 4 weeks ago

I did some work to be a bit more explicit about some type coercions with double/DateTime.

Note the code for double coercion is commented out; the tests I wrote for coercion of doubles value in differently formatted cells all passed before the change; I left the code commented out in case a more explicit conversion would be preferred.

quintusm commented 2 weeks ago

I have listed ExcelProvider 3.0 on NuGet. @mjdupont I would appreciate it if you can check that it is working as expected.

mjdupont commented 2 weeks ago

Thanks @quintusm. I've updated to 3.0.0 in my project and I'm no longer getting the extra row. I did not have an example in my code/files for the type coercion, so I would have to rely on the tests I had written there. That said, if the former issue was fixed, I don't know why the latter would not be. Appreciate you handling the update.

I've been away from coding for the past few days (PC and laptop both having drive issues at the same time). I've been thinking about trying to address some of the other open issues. In particular, supporting columns as Options by checking multiple values, allowing explicit type assignment when defining your ExcelProvider, maybe supporting merging multiple ranges by matching columns, rather than extending each row.

If you have any preferences for what to address or prioritize, or ideas for how you'd prefer I move forward on that, send me a message and I'll do what I can. Otherwise, if I find the time to address any of those, I'll just make the PR and hash it out in the comments.

quintusm commented 2 weeks ago

Hi @mjdupont. Thanks for the feedback. Any contributions are appreciated. I do not currently have any plans or preferences for the above. I rarely have time to work on this and usually just try to keep the dependencies up to date and check and merge incoming pull requests.