fsprojects / ExcelProvider

This library is for the .NET platform implementing a Excel type provider.
http://fsprojects.github.io/ExcelProvider/
The Unlicense
141 stars 51 forks source link

Cannot access columns where headers are multiline-cells #19

Closed ntr closed 6 years ago

ntr commented 9 years ago

If header cell has multiline content type provider generates multiline property name. Code that accesses these properties does not compile.

I am getting something like:

[for x in book.Data -> x.``this
is 
a test``]
ntr commented 9 years ago

Added PR #20 with a fix, unfortunately build is failing on CI server

abhiranjankumar00 commented 8 years ago

Hi, is there any improvements here?

forki commented 8 years ago

Let me check if I can merge the PR

forki commented 8 years ago

Should be fixed on nuget. On Jan 15, 2016 14:48, "pbbwfc" notifications@github.com wrote:

This issue was moved to pbbwfc/ExcelProvider4#1 https://github.com/pbbwfc/ExcelProvider4/issues/1

— Reply to this email directly or view it on GitHub https://github.com/fsprojects/ExcelProvider/issues/19#issuecomment-171965749 .

pbbwfc commented 8 years ago

Sorry about the move message - I was trying to take a copy for my Fork and incorrectly ran a tool which tried to move rather than copy the issue.

I intend to look at this issue in my fork and see if I can fix it.

forki commented 8 years ago

fixing is nice, but you should still keep the issue / disucssion here.

pbbwfc commented 8 years ago

Sorry again - my mistake - I will definitely put the discussion here once I have found something useful.

(I have done some work on the gh-pages - let me know if you think it would be useful to use these changes.)

forki commented 8 years ago

please submit docs changes as Prs to https://github.com/fsprojects/ExcelProvider/blob/master/docs/content/index.fsx

the gh-pages branch is automatically generated from there.

pbbwfc commented 8 years ago

I tried this and could not find a problem. It also seems to be already included in the tests - see test

``Multiline column name should be converted to a single line``

I tried a slightly more complex test with a four line header:

  rows.[0].``this\nis \na\ntest``

and it seemed to work OK.

Is there an example that does not work or should it be closed?