Closed pbbwfc closed 8 years ago
pbbwfc
commented
8 years ago pbbwfc
commented
8 years ago I hope this is OK and clear. Please just let me know if you want me to make any changes or if I have made any mistakes. Thanks Phil Brooks
pbbwfc
commented
8 years ago I just wanted to add that you can see the effect of the changes in http://pbbwfc.github.io/ExcelProvider/
forki
commented
8 years ago this is awesome!
forki
commented
8 years ago argh.
somehow this breaks the build on my machine again.
@pbbwfc to get it out asap. can you please send a PR with the generated docs to the gh-pages branch? (just as temp solution)
@matthid any ideas why 600236a7fa64fd9b76405bd8c2cb606ef5064784 works for me and 349249a172eb6af1ca8de95fde354457a66dcb86 doesn't?
matthid
commented
8 years ago I think the reason might be that the ExcelProvider code is not compatible with a loaded Assembly that supports localization via resource assemblies.
In the context of FSharp.Formatting such a assembly is loaded (System.Web.Razor)
The problem is that ExcelProvider adds an incomatible global assembly handler here: https://github.com/fsprojects/ExcelProvider/blob/master/src/ExcelProvider/ExcelProvider.fs#L116 The handler simply tries to load the assembly which it cannot (it really should ignore calls it can't handle by returning null).
It is not visible on travis because the runtime will not try to find a localized version as the assembly itself already has the correct localization so the runtime will not try to load additional assemblies there [1].
As a side-note: I think ExcelProvider should remove the event handler when it is no longer required or register a single global handler.
[1] https://msdn.microsoft.com/en-us/library/system.appdomain.assemblyresolve%28v=vs.110%29.aspx
forki
commented
8 years ago Can you please help me out with a pull request? I'd love to get these docs out on the Web. Thanks On Jan 17, 2016 00:32, "Matthias Dittrich" notifications@github.com wrote:
I think the reason might be that the ExcelProvider code is not compatible with a loaded Assembly that supports localization via resource assemblies.
In the context of FSharp.Formatting such a assembly is loaded (System.Web.Razor)
The problem is that ExcelProvider adds an incomatible global assembly handler here: https://github.com/fsprojects/ExcelProvider/blob/master/src/ExcelProvider/ExcelProvider.fs#L116 The handler simply tries to load the assembly which it cannot (it really should ignore calls it can't handle by returning null).
It is not visible on travis because the runtime will not try to find a localized version as the assembly itself already has the correct localization so the runtime will not try to load additional assemblies there [1].
As a side-note: I think ExcelProvider should remove the event handler when it is no longer required or register a single global handler.
[1] https://msdn.microsoft.com/en-us/library/system.appdomain.assemblyresolve%28v=vs.110%29.aspx
— Reply to this email directly or view it on GitHub https://github.com/fsprojects/ExcelProvider/pull/23#issuecomment-172272327 .
pbbwfc
commented
8 years ago Steffen,
Sorry I have not been online for a few hours.
Looks like things have moved on a bit – not sure what you want me to do. It looks like you have taken in the changes to the master branch but the docs on http://fsprojects.github.io/ExcelProvider/ have not been updated (and gh-pages branch hasn’t changed).
Have you tried running “build ReleaseDocs” to update the gh-pages branch or is that not working?
Regards
Phil Brooks
From: Steffen Forkmann [mailto:notifications@github.com] Sent: Saturday, January 16, 2016 11:36 PM To: fsprojects/ExcelProvider ExcelProvider@noreply.github.com Cc: pbbwfc phil.brooks@asr-services.com Subject: Re: [ExcelProvider] Extended docs (#23)
Can you please help me out with a pull request? I'd love to get these docs out on the Web. Thanks On Jan 17, 2016 00:32, "Matthias Dittrich" <notifications@github.com mailto:notifications@github.com > wrote:
I think the reason might be that the ExcelProvider code is not compatible with a loaded Assembly that supports localization via resource assemblies.
In the context of FSharp.Formatting such a assembly is loaded (System.Web.Razor)
The problem is that ExcelProvider adds an incomatible global assembly handler here: https://github.com/fsprojects/ExcelProvider/blob/master/src/ExcelProvider/ExcelProvider.fs#L116 The handler simply tries to load the assembly which it cannot (it really should ignore calls it can't handle by returning null).
It is not visible on travis because the runtime will not try to find a localized version as the assembly itself already has the correct localization so the runtime will not try to load additional assemblies there [1].
As a side-note: I think ExcelProvider should remove the event handler when it is no longer required or register a single global handler.
[1] https://msdn.microsoft.com/en-us/library/system.appdomain.assemblyresolve%28v=vs.110%29.aspx
— Reply to this email directly or view it on GitHub https://github.com/fsprojects/ExcelProvider/pull/23#issuecomment-172272327 .
— Reply to this email directly or view it on GitHub https://github.com/fsprojects/ExcelProvider/pull/23#issuecomment-172272706 . https://github.com/notifications/beacon/AEJVomPD4VLBfqTHFHvcz5vhX2vw43GBks5pastNgaJpZM4HGUAF.gif
forki
commented
8 years ago There is a new pr which tries to fix the docs build. Will try that On Jan 17, 2016 1:34 PM, "pbbwfc" notifications@github.com wrote:
Steffen,
Sorry I have not been online for a few hours.
Looks like things have moved on a bit – not sure what you want me to do. It looks like you have taken in the changes to the master branch but the docs on http://fsprojects.github.io/ExcelProvider/ have not been updated (and gh-pages branch hasn’t changed).
Have you tried running “build ReleaseDocs” to update the gh-pages branch or is that not working?
Regards
Phil Brooks
From: Steffen Forkmann [mailto:notifications@github.com] Sent: Saturday, January 16, 2016 11:36 PM To: fsprojects/ExcelProvider ExcelProvider@noreply.github.com Cc: pbbwfc phil.brooks@asr-services.com Subject: Re: [ExcelProvider] Extended docs (#23)
Can you please help me out with a pull request? I'd love to get these docs out on the Web. Thanks On Jan 17, 2016 00:32, "Matthias Dittrich" <notifications@github.com mailto:notifications@github.com > wrote:
I think the reason might be that the ExcelProvider code is not compatible with a loaded Assembly that supports localization via resource assemblies.
In the context of FSharp.Formatting such a assembly is loaded (System.Web.Razor)
The problem is that ExcelProvider adds an incomatible global assembly handler here:
https://github.com/fsprojects/ExcelProvider/blob/master/src/ExcelProvider/ExcelProvider.fs#L116 The handler simply tries to load the assembly which it cannot (it really should ignore calls it can't handle by returning null).
It is not visible on travis because the runtime will not try to find a localized version as the assembly itself already has the correct localization so the runtime will not try to load additional assemblies there [1].
As a side-note: I think ExcelProvider should remove the event handler when it is no longer required or register a single global handler.
[1]
https://msdn.microsoft.com/en-us/library/system.appdomain.assemblyresolve%28v=vs.110%29.aspx
— Reply to this email directly or view it on GitHub < https://github.com/fsprojects/ExcelProvider/pull/23#issuecomment-172272327
.
— Reply to this email directly or view it on GitHub < https://github.com/fsprojects/ExcelProvider/pull/23#issuecomment-172272706> . < https://github.com/notifications/beacon/AEJVomPD4VLBfqTHFHvcz5vhX2vw43GBks5pastNgaJpZM4HGUAF.gif>
— Reply to this email directly or view it on GitHub https://github.com/fsprojects/ExcelProvider/pull/23#issuecomment-172320272 .
forki
commented
8 years ago new docs are online. thx everybody
