Update handling of parameters

fsprojects / ExcelProvider

This library is for the .NET platform implementing a Excel type provider.

http://fsprojects.github.io/ExcelProvider/

The Unlicense

141 stars 51 forks source link

Update handling of parameters #25

Closed pbbwfc closed 8 years ago

pbbwfc commented 8 years ago

Make treatment in line with CSV Type Provider in F# Data - see https://github.com/fsharp/FSharp.Data/blob/master/src/Csv/CsvProvider.fs
Clarifies parameter usage and allows use of parameter labels
Allows SheetName and Range to be used together
Provides changes needed to support fix for Issue #15
Added XML Documentation for type
Updated tests appropriately
Updated docs appropriately NOTE - This change will make some existing code no longer work - e.g. see changes to tests.

forki commented 8 years ago

ok this is breaking?

since we are below 1.0 I will just increase the minor

pbbwfc commented 8 years ago

Thanks - OK if I do the change for Issue 15?

forki commented 8 years ago

Sure. Keep the awesomeness coming On Jan 19, 2016 12:55, "pbbwfc" notifications@github.com wrote:

Thanks - OK if I do the change for Issue 15 https://github.com/fsprojects/ExcelProvider/issues/15?

— Reply to this email directly or view it on GitHub https://github.com/fsprojects/ExcelProvider/pull/25#issuecomment-172828414 .