fsprojects / ExcelProvider

This library is for the .NET platform implementing a Excel type provider.
http://fsprojects.github.io/ExcelProvider/
The Unlicense
141 stars 51 forks source link

Several enhancements to the Excel Type Provider #3

Closed JohnDoeKyrgyz closed 10 years ago

JohnDoeKyrgyz commented 10 years ago

1) Upgrading to the latest version of the ExcelDataReader library. 2) Handling loading higher version of ICSharpCode.SharpZipLib. 3) Defaulting to the first sheet in the spreadsheet if a sheet is not specifically indicated. 4) Using a Row type, with a ToString() method

These fixes will make the F# Excel Type Provider more usable, and help address some of the issues causing https://github.com/fsprojects/fsharpx/issues/274. To completely fix this issue, we will need to publish an updated NuGet package.

I would be glad to update the configuration for the NuGet package if someone could offer some guidance as to where the existing configuration is.

I originally submitted this pull request to https://github.com/fsprojects/fsharpx, and @ovatsus suggested that I resubmit it here.

forki commented 10 years ago

Thanks. It's pushed to nuget.

forki commented 10 years ago

are you interested in becoming a maintainer/admin for this project?

JohnDoeKyrgyz commented 10 years ago

Hello forki,

Yes, I would be interested in being a maintainer for this project. I use it fairly frequently.

Thanks, John Atwood

forki commented 10 years ago

Done.

Is "build.cmd Release" working on your machine?

JohnDoeKyrgyz commented 10 years ago

Hello Steffen,

Build.cmd "Release" works up until it tries to checkout the gh-pages branch. Do I need to do something to set up my credentials in the git repository? I usually have to provide them when prompted.

Here is the error message:

[image: Inline image 1]

On Wed, Mar 26, 2014 at 3:04 AM, Steffen Forkmann notifications@github.comwrote:

Done.

Is "build.cmd Release" working on your machine?

Reply to this email directly or view it on GitHubhttps://github.com/fsprojects/ExcelProvider/pull/3#issuecomment-38661871 .

JohnDoeKyrgyz commented 10 years ago

Should I be using a clone of the project itself, or a clone of my fork of the project?

On Wed, Mar 26, 2014 at 9:58 AM, John Atwood johndoekyrgyz@gmail.comwrote:

Hello Steffen,

Build.cmd "Release" works up until it tries to checkout the gh-pages branch. Do I need to do something to set up my credentials in the git repository? I usually have to provide them when prompted.

Here is the error message:

[image: Inline image 1]

On Wed, Mar 26, 2014 at 3:04 AM, Steffen Forkmann < notifications@github.com> wrote:

Done.

Is "build.cmd Release" working on your machine?

Reply to this email directly or view it on GitHubhttps://github.com/fsprojects/ExcelProvider/pull/3#issuecomment-38661871 .

forki commented 10 years ago

you can use this clone.

forki commented 10 years ago

does this work? https://github.com/fsprojects/ExcelProvider/commit/37605a7c6381dd86a4f113c578256ee2b4ba12e9

JohnDoeKyrgyz commented 10 years ago

Yes!

On Wed, Mar 26, 2014 at 10:03 AM, Steffen Forkmann <notifications@github.com

wrote:

does this work? 37605a7https://github.com/fsprojects/ExcelProvider/commit/37605a7c6381dd86a4f113c578256ee2b4ba12e9

Reply to this email directly or view it on GitHubhttps://github.com/fsprojects/ExcelProvider/pull/3#issuecomment-38702573 .

forki commented 10 years ago

ok cool. what's your nuget name?

JohnDoeKyrgyz commented 10 years ago

Okay, I am JohnDoeKyrgyz on nuget.

What do I do to publish to nuget?

On Wed, Mar 26, 2014 at 10:17 AM, John Atwood johndoekyrgyz@gmail.comwrote:

Yes!

On Wed, Mar 26, 2014 at 10:03 AM, Steffen Forkmann < notifications@github.com> wrote:

does this work? 37605a7https://github.com/fsprojects/ExcelProvider/commit/37605a7c6381dd86a4f113c578256ee2b4ba12e9

Reply to this email directly or view it on GitHubhttps://github.com/fsprojects/ExcelProvider/pull/3#issuecomment-38702573 .

forki commented 10 years ago

"Sorry, JohnDoeKyrgyz hasn't verified their email account yet and we cannot proceed with the request."

Apart from that: Create a file called release.cmd in the root of the solution.

@echo off
cls
if not exist packages\FAKE\tools\Fake.exe (
  .nuget\nuget.exe install FAKE -OutputDirectory packages -ExcludeVersion -Prerelease
)
packages\FAKE\tools\FAKE.exe build.fsx Release "NugetKey=MYNUGETKEY"
pause

replace MYNUGETKEY with your key.

Make sure you don't commit this file (but it should already be in the .gitignore)

Then edit the RELEASE_NOTES.md and run release.cmd

JohnDoeKyrgyz commented 10 years ago

Hello Steffen,

I just verified by nuget account.

Try again.

Thanks, John Atwood

On Wed, Mar 26, 2014 at 11:06 AM, Steffen Forkmann <notifications@github.com

wrote:

"Sorry, JohnDoeKyrgyz hasn't verified their email account yet and we cannot proceed with the request."

Apart from that: Create a file called release.cmd in the root of the solution.

@echo off cls if not exist packages\FAKE\tools\Fake.exe ( .nuget\nuget.exe install FAKE -OutputDirectory packages -ExcludeVersion -Prerelease ) packages\FAKE\tools\FAKE.exe build.fsx Release "NugetKey=MYNUGETKEY" pause

replace MYNUGETKEY with your key.

Make sure you don't commit this file (but it should already be in the .gitignore)

Then edit the RELEASE_NOTES.md and run release.cmd

Reply to this email directly or view it on GitHubhttps://github.com/fsprojects/ExcelProvider/pull/3#issuecomment-38710750 .

forki commented 10 years ago

I’m still getting „Sorry, JohnDoeKyrgyz hasn't verified their email account yet and we cannot proceed with the request.”

forki commented 10 years ago

Now it worked.

Please try to merge the open pull request, modify the RELEASE_NOTES,md and use your release.cmd ;-)

JohnDoeKyrgyz commented 10 years ago

Hi Steffen,

I merged the latest pull request, but I did not use the release.cmd. The change was for a unit test only, and I didn't think it warranted updating the NuGet package.

I plan to update the .nuspec file to add a dependency to the ExcelDataReader package. I'll test the release.cmd when I get this working.

Correct me if you think that this most recent change would have warranted running the release.cmd.

Thanks, John Atwood

On Thu, Mar 27, 2014 at 2:03 AM, Steffen Forkmann notifications@github.comwrote:

Now it worked.

Please try to merge the open pull request, modify the RELEASE_NOTES,md and use your release.cmd ;-)

Reply to this email directly or view it on GitHubhttps://github.com/fsprojects/ExcelProvider/pull/3#issuecomment-38777123 .

forki commented 10 years ago

No. I didn't really look into it. All is well

stuartjdavies commented 10 years ago

Hi got the latest on Nuget and it doesn't seem to work. Any ideas?

forki commented 10 years ago

what is "it" exactly?

stuartjdavies commented 10 years ago

The type provider 'FSharpx.TypeProviders.ExcelProvider+ExcelProvider' reported an error: Could not load file or assembly 'Excel, Version=2.1.0.0, Culture=neutral, PublicKeyToken=93517dbe6a4012fa' or one of its dependencies. The system cannot find the file specified.

stuartjdavies commented 10 years ago

Hi,

Just wondering how I can solve the issue above as it was a previous issue.

Stuart

JohnDoeKyrgyz commented 10 years ago

Hello Stuart,

The issue is that the ExcelProvider NuGet package does not reference the ExcelDataReader nuget package as a dependency. To fix this issue, someone would need to update the package manifest, and publish a new version of the package on nuget.

I can help you with this if you are interested. I will also have time to do it later this weekend.

Thanks, John Atwood

On Tue, Jul 22, 2014 at 8:55 PM, stuartjdavies notifications@github.com wrote:

Hi,

Just wondering how I can solve the issue above as it was a previous issue.

Stuart

— Reply to this email directly or view it on GitHub https://github.com/fsprojects/ExcelProvider/pull/3#issuecomment-49827620 .

forki commented 10 years ago

Could please test version 0.1.1? I just added the niget dependecies.

JohnDoeKyrgyz commented 10 years ago

Hello Steffen,

I was able to test your updated nuget package, and it works!

Thanks, John Atwood

On Thu, Jul 24, 2014 at 1:23 AM, Steffen Forkmann notifications@github.com wrote:

Could please test version 0.1.1? I just added the niget dependecies.

— Reply to this email directly or view it on GitHub https://github.com/fsprojects/ExcelProvider/pull/3#issuecomment-49975427 .

stuartjdavies commented 10 years ago

Cheers, it works now.

stuartjdavies commented 10 years ago

Thanks for the help John and forki