fsprojects / ExcelProvider

This library is for the .NET platform implementing a Excel type provider.
http://fsprojects.github.io/ExcelProvider/
The Unlicense
141 stars 51 forks source link

Migrates to SDK style project files #48

Closed ChrSteinert closed 6 years ago

ChrSteinert commented 6 years ago

Initially, without much change, this migrates to the new project file format.

ChrSteinert commented 6 years ago

The problem seems to be, that AppVeyor uses on older MSBuild version. @forki can you help me out here?

forki commented 6 years ago

maybe https://github.com/SAFE-Stack/SAFE-BookStore/blob/master/appveyor.yml#L10 ??

ChrSteinert commented 6 years ago

Can you check what image is running there? Maybe we need the VS2017 image for MSBuild 15‽

forki commented 6 years ago

no idea

ChrSteinert commented 6 years ago

Can you easily change the image?

forki commented 6 years ago

no idea. I did not configure it.

ChrSteinert commented 6 years ago

https://ci.appveyor.com/project/SteffenForkmann/excelprovider/ … I just assumed. Will look around myself 😉

ChrSteinert commented 6 years ago

Perfect - now only to test to go!

ChrSteinert commented 6 years ago

🎉

forki commented 6 years ago

hugs!

quintusm commented 6 years ago

Any chance of getting this pull request merged?

dsyme commented 6 years ago

Apologies for the delay. Would someone like to come on as co-maintainer for this repo? I'll help for now :)

quintusm commented 6 years ago

HI Don

I would not mind becoming a maintainer, not sure if I am competent though. Will definitely need assistance initially. If somebody more experienced volunteers I would not be offended if you rather select them.

I am an active user of this type provider in a production app, though, so I have some vested interest in it's being moved forward...

dsyme commented 6 years ago

Hi @quintusm, That's great! I can add you as a co-maintainer. I will try to help you.

What is your nuget.org handle?

quintusm commented 6 years ago

HI @dsyme. I haven't been registered on nuget.org before as I have never needed to be. I have done so now though, my handle there is also qmarais

dsyme commented 6 years ago

@quintusm OK, you are now registered

quintusm commented 6 years ago

Thanks Don

And thank you very much for the recent changes made. Its fantastic.

Regards

Quintus Marais

From: Don Syme notifications@github.com Sent: Friday, 14 September 2018 19:27 To: fsprojects/ExcelProvider ExcelProvider@noreply.github.com Cc: Quintus Marais quintus.marais@kwilibri.com; Mention mention@noreply.github.com Subject: Re: [fsprojects/ExcelProvider] Migrates to SDK style project files (#48)

@quintusmhttps://github.com/quintusm OK, you are now registered

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/fsprojects/ExcelProvider/pull/48#issuecomment-421428608, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABJo03GKfT0eSqIm203JsB9AxTK6RKr8ks5ua-bmgaJpZM4SE8Ql.