search

fsprojects / ExcelProvider

This library is for the .NET platform implementing a Excel type provider.
http://fsprojects.github.io/ExcelProvider/
The Unlicense
141 stars 51 forks source link

Read from stream #82

Closed plainionist closed 3 years ago

plainionist commented 3 years ago

This change allows reading Excel files from stream. In order to support different excel formats (which were previously detected from file extension) a union type has been introduced. I added one unit test and tested the new constructor in my local project and it worked fine.

Hint: this change also removed all TargetFrameworks except .NetStandard 2.0 in order to be able to compile in VS2019. Feel free to omit these changes

quintusm commented 3 years ago

HI @plainionist

Thanks for the pull request. Just a note to say that I am actually busy working on getting the main branch into working order again. As part of the process I will include the changes from this pull request. This should not take more than a couple of days.

plainionist commented 3 years ago

hi @quintusm,

sound great! thx! looking forward to see those changes in master and on nuget ;-)

quintusm commented 3 years ago

HI @plainionist

I am ready to look at your pull request and get it merged and published to nuget, but we have conflicting changes.

Can you maybe have a look and resolve the merged changes or alternatively do a new pull request based of the updated master branch?

If this is not feasible, let me know and I will do it on my side, but that might mean that the changes can no longer be attributed to you, and I would like make sure you get the credit!

My apologies for making conflicting changes before getting to this pull request.

quintusm commented 3 years ago

Hi @plainionist

I have merged this pull request into master. Will publish a new nuget package including this change over the weekend as v2.0.0-rc3. If no issues are reported during the week I will promote that package to V2.0.0.

Thank you very much for your valued contribution.

plainionist commented 3 years ago

hi @quintusm,

sorry for the late response - i was on vacation and couldn't reply earlier. thx a lot for merging my pull request! looking forward to integrate the new version into my project ;-)