seems fixed sheetname issues like

fsprojects / ExcelProvider

This library is for the .NET platform implementing a Excel type provider.

http://fsprojects.github.io/ExcelProvider/

The Unlicense

141 stars 51 forks source link

seems fixed sheetname issues like #91

Closed ingted closed 7 months ago

ingted commented 7 months ago

seems fixed sheetname issues like https://github.com/fsprojects/ExcelProvider/issues/77

quintusm commented 7 months ago

Looks promising. I will have a look and merge if it seems correct.

Thank you for contribution

quintusm commented 7 months ago

I would like to create a test to show the failure case before pulling this pull request. Then we can confirm and illustrate that it fixes the issue. And make sure it doesn't get broken again in future.

ingted commented 7 months ago

If it's ok, I would like to help to create the tests (however I need several days to get to know about the testing stuff in this repo and then create the test cases). How would you like it? @quintusm

quintusm commented 7 months ago

That will be very cool. I am happy to let you work on it and then you can ask me at any time if you get stuck with something or need assistance, and I will try to help you.

ingted commented 7 months ago

I suddenly bump into an issue that the only way; which I could figure out now; is to send the code into a fsi session on the fly... or the test project is not buildable... however it sounds really heavy to start a FsiEvaluationSession object -> evaluate the script having the ExcelProvider library loaded -> determine the test result by the diagnose messages return by the fsi session...

Do you like the fsi way? @quintusm If yes, I think I know how to develop the test cases now.

ingted commented 7 months ago

PS. When I try to use paket to add Microsoft.NET.Test.Sdk into test project, it succeeded but the reference doesn't show up in Packages section of the project.

dotnet paket add Microsoft.NET.Test.Sdk

So I need to add

<ItemGroup>
  <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.9.0" />
</ItemGroup>

into fsproj file to make "Run Tests" shown in right-click menu of the project... What's the correct way to add the dependency?

quintusm commented 7 months ago

What IDE are you using? Visual Studio, VSCode or something else?

For now please be aware that if you run the build it also runs the tests. If all the tests pass the RunTests target will be successful.

You can also run the following command : dotnet fake run build.fsx --target RunTests

quintusm commented 7 months ago

What IDE are you using? Visual Studio, VSCode or something else?

For now please be aware that if you run the build it also runs the tests. If all the tests pass the RunTests target will be successfull.

You can also run the following command : dotnet fake run build.fsx --target RunTests

quintusm commented 7 months ago

Adding Microsoft.NET.Test.Sdk to the paket.references file in the ExcelProvider.Tests folder should have the same effect as adding the itemgroup reference in the project file

ingted commented 7 months ago

Created another PR. https://github.com/fsprojects/ExcelProvider/pull/93

ingted commented 7 months ago

Changed to this PR. https://github.com/fsprojects/ExcelProvider/pull/94