fsprojects / ExcelProvider

This library is for the .NET platform implementing a Excel type provider.
http://fsprojects.github.io/ExcelProvider/
The Unlicense
141 stars 51 forks source link

Fix issues related to sheet name #94

Closed ingted closed 8 months ago

ingted commented 9 months ago
  1. Throw exception with invalid sheetname during designtime
  2. Schema should be always useful for any existed sheet specified during runtime (invalid type data would cause exception)

Added two unit tests.

image

Clean clone and FAKE build passed.

image

ingted commented 9 months ago

Hi @quintusm, I think I finished so far, do you like it? Or do you have any suggestions that the test cases could be adjusted/ improved?

quintusm commented 9 months ago

Hi @quintusm, I think I finished so far, do you like it? Or do you have any suggestions that the test cases could be adjusted/ improved?

I'm sorry, I haven't had time to look at it and will be couple of days before I can...