search

fsprojects / FAKE

FAKE - F# Make
https://fake.build
Other
1.28k stars 581 forks source link

Core.Process: only set StandardEncoding if output/err is redirected #2672

Closed knocte closed 1 year ago

knocte commented 2 years ago

Description

Should potentially fix https://github.com/fsprojects/FAKE/issues/2670

knocte commented 2 years ago

@yazeedobaid I guess it was you who whitelisted me so that CI could run in this PR? I believe the macOS lane is not broken by my PR but because of a different issue which I filed here: https://github.com/fsprojects/FAKE/issues/2671

yazeedobaid commented 2 years ago

@knocte yes I approved the CI run. For first-time contributors, the CI needs admin approval. Yes, it is not from your PR. It started to happen randomly after the last PR merge. It is happening on macOS only.

yazeedobaid commented 2 years ago

Hi thanks for the PR Could you please rebase your branch from release/next? Now that the build has been fixed.

knocte commented 2 years ago

Could you please rebase your branch from release/next?

Done.

yazeedobaid commented 1 year ago

Thanks for the fix, can u please try to add tests to it?