search

fsprojects / FAKE

FAKE - F# Make
https://fake.build
Other
1.28k stars 582 forks source link

Bump Version in Build is Causing Version issues after a Release #2685

Closed yazeedobaid closed 1 year ago

yazeedobaid commented 1 year ago

Description

After each release of FAKE, the build script updates the DotNet fake-cli tool in the tools JSON file in the repository with version 1.0.0-1. The update happens as a way to pick up the newly released version of FAKE CLI and use it in the repository codebase. However, the version that the build set is not the most recent one and will cause subsequent builds to fail and it needs a manual fix to set the correct version in DotNet tools file.

Please see this line.

Repro steps

Please provide the steps required to reproduce the problem

  1. Create a new release of FAKE.
  2. Watch a new bump commit is added to Git history which updates the version of fake-cli in the tools file. Example commit

Expected behavior

Please provide a description of the behavior you expect. After FAKE is released, the newly released version of the FAKE runner should be added to DotNet tools file.

Actual behavior

Versions 1.0.0-1 is being committed to Git history.

Known workarounds

manual change after each release to use newest version.

yazeedobaid commented 1 year ago

More info: So in GitHub workflows, we build FAKE runner with a version of 1.0.0-1 and then add it as a DotNet tool. This was done in this way to dogfood the build with the latest changes in the runner. Now since fake-cli tool is added to the solution with that version. Then when committing the bump version commit, it will use that version.