fsprojects / FAKE

FAKE - F# Make
https://fake.build
Other
1.28k stars 585 forks source link

Update version of Paket #2714

Closed mk185147 closed 1 year ago

mk185147 commented 1 year ago

Description

Current version of Fake contains Paket that isn't able to work with .NET 7 or nuget assemblies that talk about .NET 7 in dependency. I have updated Paket.Core to latest stable version which resulted in updating a few more packages which required small chagnes to code.

yazeedobaid commented 1 year ago

Thanks a lot! 🚀 🚀

BlythMeister commented 1 year ago

@yazeedobaid is there any chance of getting this into the fake 5.x versions? as 6.x isn't released yet this is causing issues on a paket update

yazeedobaid commented 1 year ago

@BlythMeister sure I can release a version for FAKE 5, can anyone send a PR to the 5.x branch? Also, is there anything preventing you from using FAKE v6 apart from not being released yet?

BlythMeister commented 1 year ago

I haven't tried as it's not released and as a company we actively avoid pre-release dependencies.

BlythMeister commented 1 year ago

@yazeedobaid i tried to do a PR to update paket. but getting issues with it building. (#2730) noticed some other updates have been made for the net7 release, but i just can't get fake5 to build at all anymore!

even if i make a trivial change to the branch, the CI won't actually build it (#2731)

yazeedobaid commented 1 year ago

@BlythMeister Thanks for sending a PR. I didn't look into the complete details, but it seems issues are caused by dependencies resolutions by FAKE runner. Not sure if it is related to it, but we had also to drop support for NETSTANDARD 2.0 in the FAKE runner for it to work with updated dependencies.

The pre-releases of v6 are out by now for almost 3 months. I think we can publish the first stable release of it. Does this work for you? I can plan for a release early next week.

BlythMeister commented 1 year ago

Yeah, I can wait for that 🙂

yazeedobaid commented 1 year ago

@BlythMeister I have published the 6.0.0 version.