Closed gdziadkiewicz closed 1 year ago
Thanks for contributing. Could you please rebase your branch from master? We have fixed the failing build. Also, could you please provide a description of the PR?
Yes, will do that
From: Yazeed Obaid @.> Sent: Friday, November 18, 2022 11:49:40 AM To: fsprojects/FAKE @.> Cc: Grzegorz Dziadkiewicz @.>; Author @.> Subject: Re: [fsprojects/FAKE] Add ignoreConflicts parameter to paket push (PR #2720)
Thanks for contributing. Could you please rebase your branch from master? We have fixed the failing build. Also, could you please provide a description of the PR?
— Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ffsprojects%2FFAKE%2Fpull%2F2720%23issuecomment-1319834697&data=05%7C01%7C%7Ca515bef3ee1e42366eb408dac95298b2%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638043653828658628%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=BVUT%2BIgptGOXIU%2FGD5mz3%2F%2BNE6rj0m0kODFPR0LFh%2FE%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACBG4D6GLLWHHGDWCFKAB4LWI5NMJANCNFSM6AAAAAASAYBCR4&data=05%7C01%7C%7Ca515bef3ee1e42366eb408dac95298b2%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638043653828658628%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=aOOJ8IiEv3NQte4OU8WjJd6yeCRKkDOXWDeKFOYuKZs%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.***>
Refreshed the branch with master and added a description. I will do some more testing and provide the test results here before progressing from draft.
Thanks! Released in 6.0.0-beta001
Description
Add missing parameter
ignoreConflicts
frompaket push
TODO
Feel free to open the PR and ask for help
[x] New (API-)documentation for new features exist (Note: API-docs are enough, additional docs are in
help/markdown
)[x] unit or integration test exists (or short reasoning why it doesn't make sense)
[x] boy scout rule: "leave the code behind in a better state than you found it" (fix warnings, obsolete members or code-style in the places you worked in)
[x] (if new module) the module has been linked from the "Modules" menu, edit
help/templates/template.cshtml
, linking to the API-reference is fine.[x] (if new module) the module is in the correct namespace
[x] (if new module) the module is added to Fake.sln (
dotnet sln Fake.sln add src/app/Fake.*/Fake.*.fsproj
)[x] Fake API guideline is honored