Closed gtbuchanan closed 4 months ago
@gtbuchanan I'm a new maintainer. Do you want to finish your PR?
So what needs to be done to get this finished? (There are a few more versions post the one updated to here, and the release notes for the latest one says that it adds support for another new binlog format version, so maybe it should be jumped up to that version)
maybe it should be jumped up to that version
Or not, seems that updating the microsoft.build deps to 17.5 causes the integration tests to fail with the error described in https://github.com/fsprojects/FAKE/issues/2722, so maybe leaving the min version at 2.1.815 that works with the older MSBuild versions would be safest (that should still support the v16 binlog format)
@Numpsy OK, will you submit a PR?
Description
Updated with
paket update MSBuild.StructuredLogger --group fakemodule
Resolves: #2744
TODO
[ ] New (API-)documentation for new features exist (Note: API-docs are enough, additional docs are in
help/markdown
)[ ] unit or integration test exists (or short reasoning why it doesn't make sense)
[x] boy scout rule: "leave the code behind in a better state than you found it" (fix warnings, obsolete members or code-style in the places you worked in)
[ ] (if new module) the module has been linked from the "side navigation" menu, edit
docs/data.json
.[ ] (if new module) the module is in the correct namespace.
[ ] (if new module) the module is added to Fake.sln (
dotnet sln Fake.sln add src/app/Fake.*/Fake.*.fsproj
)[x] Fake API guideline is honored