fsprojects / FAKE

FAKE - F# Make
https://fake.build
Other
1.28k stars 582 forks source link

Bump MSBuild.StructuredLogger to 2.1.820 #2746

Closed gtbuchanan closed 4 months ago

gtbuchanan commented 1 year ago

Description

Updated with paket update MSBuild.StructuredLogger --group fakemodule

Resolves: #2744

TODO

xperiandri commented 9 months ago

@gtbuchanan I'm a new maintainer. Do you want to finish your PR?

Numpsy commented 8 months ago

So what needs to be done to get this finished? (There are a few more versions post the one updated to here, and the release notes for the latest one says that it adds support for another new binlog format version, so maybe it should be jumped up to that version)

Numpsy commented 8 months ago

maybe it should be jumped up to that version

Or not, seems that updating the microsoft.build deps to 17.5 causes the integration tests to fail with the error described in https://github.com/fsprojects/FAKE/issues/2722, so maybe leaving the min version at 2.1.815 that works with the older MSBuild versions would be safest (that should still support the v16 binlog format)

xperiandri commented 6 months ago

@Numpsy OK, will you submit a PR?