fsprojects / FAKE

FAKE - F# Make
https://fake.build
Other
1.28k stars 582 forks source link

add support for /tl:[auto|on|off] msbuild flag #2768

Open smoothdeveloper opened 6 months ago

smoothdeveloper commented 6 months ago

Description

see --tl:[auto|on|off] on dotnet build documentation: https://learn.microsoft.com/en-gb/dotnet/core/tools/dotnet-build

Since this only works with dotnet sdk >= 8, the default case (specifying Auto) will not emit the tag.

TODO

Feel free to open the PR and ask for help

smoothdeveloper commented 6 months ago

tried it (specificying TerminalLogger = On) in the build.fsx in this repository and it seems to work:

image

smoothdeveloper commented 6 months ago

image

now with <para/> tags.

xperiandri commented 6 months ago

Do you have any ideas why build fails?

smoothdeveloper commented 6 months ago

@xperiandri no, I see the same on another run on master branch: https://github.com/fsprojects/FAKE/actions/runs/7174371576/job/19535683031

We should investigate but I doubt it is related to this change.

xperiandri commented 6 months ago

Probably something bad with an agent. Maybe update the version of image