Numpsy commented 1 month ago

refs https://github.com/fsprojects/FAKE/issues/2738#issuecomment-2146284145

This is just grabbing a couple of notable changes, and I'm not sure what the next version will be, so maybe it's a placeholder than a complete change

Numpsy commented 1 month ago

Also, the macOS CI builds might fail unless we do https://github.com/fsprojects/FAKE/pull/2773 or update the .NET SDK or something like that

voronoipotato commented 1 month ago

Looks great! Thanks @Numpsy !! 🎉🎉🎉

xperiandri commented 4 weeks ago

Does anyone know how to fix the build?

Numpsy commented 4 weeks ago

Does anyone know how to fix the build?

If the issue is https://github.com/dotnet/runtime/issues/64103 then it looks like either change the macOS runner from macOS-latest to macOS(12/13) (e.g. #2773) or update the .NET SDK used in the build to 6.0.300 or newer.

smoothdeveloper commented 4 weeks ago

@xperiandri I noticed in #2768 (which also updates release notes) that you rebased / repushed commits I did in that branch, I think it is better to just append commits and let the branch author do rebase in case it is needed, there is also concern it can mess the contribution history in github (which is nice for people that begin contribution).

2768 should be merged and released, IMO, it is not because macOS CI fails in that particular branch, that it is related to it, most FAKE users can't leverage terminal logger goodness until it ships.

xperiandri commented 4 weeks ago

@smoothdeveloper let's fix the build in a separate PR and rebase this one on top. Anyway, if a build does not happen I will not be able to release anything. A release also requires building 🙂

smoothdeveloper commented 4 weeks ago

@xperiandri mmh, I didn't see there are artifacts for each platform.

I'm not aware of the reason for it, as I assumed there are no non-CLI binaries shipped for fake but I'm probably overlooking something.

voronoipotato commented 3 weeks ago

@xperiandri how do we update .net core to 6.0.5 for that the macOS-latest target so we can keep moving?

xperiandri commented 3 weeks ago

Submit another PR with a fix

Numpsy commented 2 weeks ago

@xperiandri how do we update .net core to 6.0.5 for that the macOS-latest target so we can keep moving?

I tried doing it in #2780 and got a different error :-(

Numpsy commented 2 weeks ago

Grasping at straws a bit here, but - https://github.com/fsprojects/FAKE/pull/2781. (Unclear if there is actually a real FAKE issue here on ARM cpu macs that might effect end users as well)

voronoipotato commented 1 week ago

@Numpsy maybe we should reach out to people in the slack and discord and see if anyone has an arm macbook that they can help test this with. I have an arm surface pro x, but I doubt that will be helpful.

Numpsy commented 1 week ago

At this point, I think it might be nice to just try to get the build pipeline running successfully on the Intel Mac runners, and have 'fix ARM problems' as a seperate work item once there's a more stable base

voronoipotato commented 1 week ago

that seems good, I hear the rosetta x86 emulation is very good anyway, it feels like a "nice to have".

fsprojects / FAKE

Update release notes #2778

2768 should be merged and released, IMO, it is not because macOS CI fails in that particular branch, that it is related to it, most FAKE users can't leverage terminal logger goodness until it ships.