Why integration tests use 6.0.100 and 6.0.101 SDKs

fsprojects / FAKE

FAKE - F# Make

https://fake.build

Other

1.28k stars 585 forks source link

Why integration tests use 6.0.100 and 6.0.101 SDKs #2792

Open xperiandri opened 1 month ago

xperiandri commented 1 month ago

I see integration tests use SDKs 6.0.100 and 6.0.101 @yazeedobaid @mclark1129 what should we do with that? As these tests fail now on CI and I want to install the latest .NET 6 SDK on CI

xperiandri commented 1 month ago

cc @TheAngryByrd @Numpsy @Thorium

Numpsy commented 1 month ago

I assumed the old versions are just because of how old the tests are, but not certain on that.

I at one point tried updating to the 6.0.300/6.0.301 SDKs in https://github.com/Numpsy/FAKE/commits/6.0.131/ and got other failures, but that was before before Paket and such were updated so maybe it was falling over those problems.

Numpsy commented 1 month ago

I got a successful CI build using the 6.0.30x SDK at https://github.com/fsprojects/FAKE/pull/2794 at any rate, though I can't say if that's missing anything with regards to the intentions of the integration tests

TheAngryByrd commented 1 month ago

So in general about feature bands

The .1xx is supported until the end of a major's lifecycle.
Additional feature bands such as .2xx .3xx .4xx are only supported specific months of that year.

So if we were trying to eliminate SDK as a source of bugs we would always need tests for the latest .1xx and the whatever is the latest of 2/3/4.

See: https://learn.microsoft.com/en-us/dotnet/core/porting/versioning-sdk-msbuild-vs#lifecycle

baronfel commented 1 month ago

I'm ~~Commander Shepard~~ Chet Husk and I approve this plan^