fsprojects / FSharp.AWS.DynamoDB

F# wrapper API for AWS DynamoDB
MIT License
58 stars 18 forks source link

Sync with canonical Async.AwaitTaskCorrect #49

Closed bartelink closed 2 years ago

bartelink commented 2 years ago

In isolating https://github.com/dotnet/fsharp/issues/13165, the fact that the AwaitTaskCorrect impl herein predates the current fsssnip edition, and that the task.InnerException is subtle led me down additional paths that would be nice to avoid, especially given that ultimately there should be convergence in the implementations via https://github.com/fsharp/fslang-suggestions/issues/840.

bartelink commented 2 years ago

NOTE there are two behavior changes here:

Ran this past @eiriktsarpalis; he confirmed there is no useful variation in the impl herein

ASIDE: Having a immediate release for this is not critical for me as I'm comfortable there is no consequential behavior change that I need - hopefully I'll get around to doing cleanup on TransactWriteItems and it can accompany that on the train