search

fsprojects / FSharp.AWS.DynamoDB

F# wrapper API for AWS DynamoDB
MIT License
58 stars 18 forks source link

Pin FSharp.Core dependency #75

Open bartelink opened 5 months ago

bartelink commented 5 months ago

Triggered by https://github.com/SwensenSoftware/unquote/issues/169

samritchie commented 5 months ago

Build failure looks like it’s related to the StructuredLogger version in build.fsx, I’ll see if I can work out what it should be

samritchie commented 5 months ago

Looks like bumping it to 2.2.206 should work - @bartelink is it easier for you to update your branch?

samritchie commented 5 months ago

Also note I’ve considered bumping FSharp.Core to 6.0.7 as it looks like it will make life easier with tasks - I’ve been working on streams support using a Task based API. Not sure of the tradeoffs here though - open to suggestions.

bartelink commented 5 months ago

I think 6.0.7 is a good call - there's probably the odd gap closed in Arrray, Seq and stuff too You should be able to push to my branch if you gh pr to retrieve it (and 101 other ways) - in general feel free to do that, but I'll try now Yes it dos stand to reason the template is gone my main thing in all of this is for the package not to get a random dependency update due to unqote some day

bartelink commented 5 months ago

(Giving up for now; have time-sensitive stuff this side...)

samritchie commented 5 months ago

Thanks @bartelink - I’m off grid the next few days but will have a look on the weekend.

On 10 Apr 2024, at 2:09 PM, Ruben Bartelink @.***> wrote:



(Giving up for now; have time-sensitive stuff this side...)

— Reply to this email directly, view it on GitHubhttps://github.com/fsprojects/FSharp.AWS.DynamoDB/pull/75#issuecomment-2046603232, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AACLRRCUXH33AJILVHHZGKDY4TJQ3AVCNFSM6AAAAABF6E5DBOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBWGYYDGMRTGI. You are receiving this because you commented.Message ID: @.***>

bartelink commented 5 months ago

Thanks; it's not time sensitive from my perspective. If unquote reduces dependency to 6.0.0, probably updating unquote can be done as a follow-up to include in the next release ... or not yet, depending on when you want to do task stuff