search

fsprojects / FSharp.Azure.Storage

F# API for using Microsoft Azure Table Storage service
MIT License
75 stars 16 forks source link

First class support URI #30

Closed coolya closed 5 years ago

coolya commented 6 years ago

Added first class support for URIs. Since the URIs are safe to be represented as a string support for them with string backing fields was added.

In my use case I have a lot of uris in my domain objects and creating DTOs just for storing URIs as string felt bad.

daniel-chambers commented 6 years ago

Thanks for the PR! I'm away this weekend, but I'll take a look next week when I'm home. :)

On Sat., 29 Sep. 2018, 8:47 am Kolja Dummann, notifications@github.com wrote:

Added first class support for URIs. Since the URIs are safe to be represented as a string support for them with string backing fields was added.

In my use case I have a lot of uris in my domain objects and creating DTOs just for storing URIs as string felt bad.

You can view, comment on, or merge this pull request online at:

https://github.com/fsprojects/FSharp.Azure.Storage/pull/30 Commit Summary

  • test if query for "None" throws exception
  • Add first class support for URI types

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/fsprojects/FSharp.Azure.Storage/pull/30, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKHkCWVCGC8Zo1pTtBJgdxZJbXHcWBXks5ufqb-gaJpZM4XAKyT .

coolya commented 6 years ago

Thanks for the quick review. I think addressed all of the formatting issues. Seems like Rider goes crazy when copy and past functions and totally messes up the indention then. :(