Fix failing IO_EndOfLine_Translations tests

fsprojects / FSharp.Compatibility

Compatibility libraries for F#

44 stars 22 forks source link

Fix failing IO_EndOfLine_Translations tests #3

Closed jmquigs closed 9 years ago

jmquigs commented 9 years ago

This is a fix for #1

InChannelImpl and OutChannelImpl must both implement IDisposable, otherwise they will leave their streams open (caused a Sharing Violation exception)
OutChannelImpl must override Write from TextWriter, or else the output will not actually be written anywhere to the stream
InChannelImpl must override Peek
input_char should throw End_of_file when a read is triggered at end of stream
in stream_to_StreamWriter, if the encoding is the default encoding, don't specify an encoding to the StreamWriter constructor. Fixes issue with mono generating a BOM in output files, which then cause the test to fail.

dsyme commented 9 years ago

These changes look good to me.

@jack-pappas - any opinions?

@jmquigs - would you be interested in also becoming an active maintainer of the project (allowing you to accept commits, though your own commits should still be submitted via PRs)

jmquigs commented 9 years ago

@dsyme - sure, becoming a maintainer sounds cool. thanks

dsyme commented 9 years ago

Hey @sergey-tihon - this reminds me, we should write a general "onboarding guide" for new project maintainers settinng out minimal expectations, code-of-conduct and responsibilities in "fsprojects". Do you think you could draft one as a PR to fsprojects.github.io project?

Also, ideally each "fsprojects" guide should also have a "Developer Guide" section in the README with brief minimal information about how to build, build docs and publish the nuget packages. Normally the first job of each new "maintainer" is to double check that the information is accurate :)

@jmquigs - we'd be glad to have you contribute to this too of course - help define an "onboarding guide" would be very appreciated!

jmquigs commented 9 years ago

@dsyme, @sergey-tihon - I'd be happy to review an onboarding guide when its available. I will also contribute a Developer Guide to the readme for this project.

dsyme commented 9 years ago

Great! :)

sergey-tihon commented 9 years ago

@dsyme I will try to come up with draft (but a bit later)