fsprojects / FSharp.Compatibility

Compatibility libraries for F#
44 stars 22 forks source link

NuGet not up-to-date? #4

Closed YaakovN closed 6 years ago

YaakovN commented 9 years ago

According to NuGet the OCaml lib was last published on there on 2013-07-07 (v0.1.10) But according to https://github.com/fsprojects/FSharp.Compatibility/commit/57861ff28d6d69dee3c6e221973926854a48fcf4, the latest changes were only applied on 2013-07-20.

The specific issue I experience after switching from the old Ocaml Combatibility library in Powerpack to yours, is that "invalid_arg" (Pervasives.fs) "is not defined". Would you mind updating the package on Nuget?

sergey-tihon commented 9 years ago

@jack-pappas Could you please update the package?

wallymathieu commented 6 years ago

Is this still valid @jmquigs ?

jmquigs commented 6 years ago

Probably. I don't think I have nugent access but I will try to update them.

On Feb 4, 2018 4:19 AM, "Oskar Gewalli" notifications@github.com wrote:

Is this still valid @jmquigs https://github.com/jmquigs ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fsprojects/FSharp.Compatibility/issues/4#issuecomment-362902593, or mute the thread https://github.com/notifications/unsubscribe-auth/AAo4unO8opTPIjVGN_0vWxzbjs5f9wgJks5tRaBNgaJpZM4DIDgo .

wallymathieu commented 6 years ago

Perhaps @forki can help with that (access to nuget)?

forki commented 6 years ago

I don't think I have access to that particular nuget package

wallymathieu commented 6 years ago

Looks like the user 'fsprojects' does have access to all of them. https://www.nuget.org/packages?q=FSharp.Compatibility @jack-pappas looks like he has access to some of them (but not all)

YaakovN commented 6 years ago

If you guys are already looking at this, would this be a good moment to add a "net standard" option? Thanks.

On 4 Feb 2018 1:02 pm, "John Quigley" notifications@github.com wrote:

Probably. I don't think I have nugent access but I will try to update them.

On Feb 4, 2018 4:19 AM, "Oskar Gewalli" notifications@github.com wrote:

Is this still valid @jmquigs https://github.com/jmquigs ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fsprojects/FSharp.Compatibility/issues/4# issuecomment-362902593, or mute the thread https://github.com/notifications/unsubscribe-auth/AAo4unO8opTPIjVGN_ 0vWxzbjs5f9wgJks5tRaBNgaJpZM4DIDgo .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/fsprojects/FSharp.Compatibility/issues/4#issuecomment-362905194, or mute the thread https://github.com/notifications/unsubscribe-auth/AJsd1UDKkrvvPAAraLNifThHJObxh6suks5tRapkgaJpZM4DIDgo .

wallymathieu commented 6 years ago

Netstandard conversion is a separate issue. Someone needs to go through the projects and change fsproj to the new format and see what breaks (and check if it's possible to target lower netstandard versions than 2.0).

wallymathieu commented 6 years ago

So who to talk to then @forki ?

forki commented 6 years ago

To the original authors. They should try to find new maintainers.

Am 04.02.2018 14:22 schrieb "Oskar Gewalli" notifications@github.com:

So who to talk to then @forki https://github.com/forki ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fsprojects/FSharp.Compatibility/issues/4#issuecomment-362906408, or mute the thread https://github.com/notifications/unsubscribe-auth/AADgNHUFnB8p2JRgpec2DXaa4S-0rnXrks5tRa8fgaJpZM4DIDgo .

wallymathieu commented 6 years ago

Looks like @jack-pappas is the original author.

dsyme commented 6 years ago

@wallymathieu We can make you an owner on the relevant packages. Is that correct?

wallymathieu commented 6 years ago

@dsyme if you want help with publishing the nuget packages, then yes.

If there is some other maintainer of this project that is willing to publish it to nuget, for instance it looks like there are maintainers with commit access to this repo that does not have nuget publish access (I do not have commit access to this repo).

jmquigs commented 6 years ago

@wallymathieu is it advisable to build one set of packages now, and then after upgrading the project to F# 4.0+, bump the version number and upload another set? Sorry if its a basic question, I'm a nuget nuub. 😄

wallymathieu commented 6 years ago

@jmquigs depends on what you win by doing that. It looks like it was a while since the nuget packages got pushed. Is there any need for code changes by changing f# compiler and FSharp.Core library?

jmquigs commented 6 years ago

@wallymathieu some of the code will need to change I'm sure. If the project is upgraded to the newer version, then @gusty can also upgrade the F#+ dependency to a more recent version, but its probably not a big priority.

wallymathieu commented 6 years ago

It looks like the Haskell, SML and OCaml compatibility projects are separate, so any change of f# and FSharp.Core can be applied to the separate subprojects.

jack-pappas commented 6 years ago

Sorry for the late reply, I was away on holiday and I'm just now catching up on emails.

Some background: I started this repo 5-6 years ago when porting some OCaml-based code to F#. I wanted to avoid changing the code more than necessary, so I created the FSharp.Compatibility.OCaml library to provide select functions from the OCaml standard library (ported so they'd work for F# / .NET). Later, I merged in some code from the old F# PowerPack which aimed to do the same thing (provide an OCaml compatibility layer). The other FSharp.Compatibility.OCaml.* subprojects are separate primarily for licensing reasons -- they contain code taken directly from the OCaml standard library so are LGPL-licensed rather than Apache 2.0 as the other projects are.

Some time later, I had some bits of Haskell and SML code I wanted to try porting to F# in the same way so I created similar projects for those languages. I started a new job not long after and put these on the back burner and they've been there ever since.

Do we actually need to add any NuGet permissions here? Or just publish new versions of the package(s)?

wallymathieu commented 6 years ago

It looks like the only relevant change to release is the FSharp.Compatibility.Haskell as far as I can see?

wallymathieu commented 6 years ago

So once that has been released, perhaps this issue can be closed?

jmquigs commented 6 years ago

@jack-pappas thanks for commenting. I think we just need to publish new versions of the packages. Other than the recent Haskell changes, I made some minor changes to the OCaml packages some time ago, mostly to fix the build, that I don't think were ever released on NuGet. So it would be nice to have new packages for Haskell and OCaml at least.

dsyme commented 6 years ago

I'm happy to have all three of you @jmquigs, @wallymathieu and @jack-pappas as co-owners. I'll update the permissions (if I can find your nuget IDs)

dsyme commented 6 years ago

Actually i can't find either of you @wallymathieu and @jmquigs :) Please list your nuget.org IDs below and we can add you as package owners

wallymathieu commented 6 years ago

I have a bit of an odd names as usual : https://www.nuget.org/profiles/ozzymcduff is the nuget user I use.

jmquigs commented 6 years ago

@dsyme Thanks! I just created my account: https://www.nuget.org/profiles/jmquigs

wallymathieu commented 6 years ago

@jmquigs let's plan what to do here then. Do you need any help or anything?

jmquigs commented 6 years ago

@wallymathieu actually I could use some help, since I haven't updated the packages before. Should I just use the travis artifacts, or is there a project here that has a reference nuget setup that I could look at?

wallymathieu commented 6 years ago

I would guess that it would be nice to just upload the artifacts to nuget. Otherwise you would need to locally do the same thing as is done on the build server. However, I can't seem to find any Appveyor artifacts or Travis artifacts?

jmquigs commented 6 years ago

It looks like the appveyor config wasn't set up to find the artifacts. I fixed that in my fork and now it is finding them: https://ci.appveyor.com/project/jmquigs/fsharp-compatibility/build/artifacts Now I just need to make the build generate the nuget files. The spec files are in the repo, so that shouldn't be hard. Then its just a version bump and a rebuild, followed by a push of the files to the NuGet Repro.

jmquigs commented 6 years ago

@wallymathieu do you have nuget access for this project now? It looks I don't have upload access. If you want to try, you can get the nupkgs from here: https://ci.appveyor.com/project/fsprojectsgit/fsharp-compatibility/build/13/artifacts

wallymathieu commented 6 years ago

Sure. I'll do that.

wallymathieu commented 6 years ago

They should be uploaded now.

wallymathieu commented 6 years ago

They are validating right now.