issues
search
fsprojects
/
FSharp.Compatibility
Compatibility libraries for F#
44
stars
22
forks
source link
Add Invalid_argument active pattern to fix failing chop_extension test
#9
Closed
jmquigs
closed
9 years ago
jmquigs
commented
9 years ago
The test is failing because it matches on an Invalid_argument exception, but the function actually throws System.ArgumentException
An Invalid_argument pattern was in the original powerpack version of this file:
https://github.com/fsprojects/powerpack/blob/93fd7200f7f46b2be281a1295a96e4a8f3ef6c7b/src/FSharp.PowerPack.Compatibility/pervasives.fs
That pattern was removed sometime before this file was committed here, but given that the "Failure" pattern was added here which does something similar, it seems to be a valid way to fix this issue
dsyme
commented
9 years ago
LGTM