search

fsprojects / FSharp.Configuration

The FSharp.Configuration project contains type providers for the configuration of .NET projects.
http://fsprojects.github.io/FSharp.Configuration/
Other
114 stars 63 forks source link

Fix ResX provider #108

Closed efoerster closed 7 years ago

efoerster commented 7 years ago

The current implementation of the ResX provider tries to read the .resx file at runtime and therefore fails when being deployed. I changed the implementation to be more in line with the C# one.

This commit fixes #73 and #46.

dsyme commented 7 years ago

This looks great

@forki @vasily-kirichenko what do you think?

vasily-kirichenko commented 7 years ago

I don't know. I'm not the author and I've never used it. Maybe someone who is using it could test this PR?

dsyme commented 7 years ago

@dtchepak any ideas?

dtchepak commented 7 years ago

@dsyme Sorry Don, i'm in the same boat as @vasily-kirichenko.

forki commented 7 years ago

So to sum up: we don't have a maintainer using this thing ;-)

rojepp commented 7 years ago

I nominate @efoerster. :) Code changes look great at a glance. Nice touch updating the screenshot. Easily overlooked.