search

fsprojects / FSharp.Configuration

The FSharp.Configuration project contains type providers for the configuration of .NET projects.
http://fsprojects.github.io/FSharp.Configuration/
Other
114 stars 63 forks source link

update ProvidedTypes form FSharp.Data #48

Closed vasily-kirichenko closed 9 years ago

vasily-kirichenko commented 9 years ago

fix memory leak caused by hiding Disposable member implemented in ProvidedTypes.

@forki @dungpa I'm not sure it's totally OK that I pick ProvidedTypes.fs/fsi from FSharp.Data repository. Where can I get the latest vanilla ProvidedTypes?

dsyme commented 9 years ago

In theory the latest is the one in the F# Type Provider Starter Pack.

sergey-tihon commented 9 years ago

As I know the latest version is it FSharp.TypeProviders.StarterPack. Am I right @mavnn?

@vasily-kirichenko Now you have a unique possibility to reference latest version using Paket. Example is here - https://github.com/mavnn/Inrush/blob/master/paket.dependencies#L13

dsyme commented 9 years ago

It would be great to get the Travis build fixed - any idea what this error is? https://travis-ci.org/fsprojects/FSharp.Configuration/builds/43840015#L467

dungpa commented 9 years ago

I think FSharp.TypeProviders.StarterPack has the latest bits. @ReedCopsey did a PR https://github.com/fsprojects/FSharp.TypeProviders.StarterPack/pull/23 to fix potential memory leaks there a few months ago.

sergey-tihon commented 9 years ago

I think that we should mention in README.md of FSharp.TypeProviders.StarterPack That is it official home for ProvidedTypes and repo contains latest version of files.

Your thoughts? @dsyme @mavnn @ReedCopsey @dungpa

dsyme commented 9 years ago

Yes, please do that. See also this discussion: https://github.com/fsprojects/VisualFSharpPowerTools/issues/474#issuecomment-66784272

mavnn commented 9 years ago

Sounds good. I'm feeling somewhat ill at the moment: if anyone gets around to sending a pull request I'll try and make sure I merge it. On 12 Dec 2014 14:51, "Sergey Tihon" notifications@github.com wrote:

I think that we should mention in README.md of FSharp.TypeProviders.StarterPack That is it official home for ProvidedTypes.fs and repo contains latest version of files.

Your thoughts? @dsyme https://github.com/dsyme @mavnn https://github.com/mavnn @ReedCopsey https://github.com/ReedCopsey @dungpa https://github.com/dungpa

— Reply to this email directly or view it on GitHub https://github.com/fsprojects/FSharp.Configuration/pull/48#issuecomment-66781697 .

vasily-kirichenko commented 9 years ago

Published in NuGet package 0.4.7